Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: chrome/browser/chromeos/login/version_info_updater.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/version_info_updater.h" 5 #include "chrome/browser/chromeos/login/version_info_updater.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
11 #include "base/strings/string_util.h" 11 #include "base/strings/string_util.h"
12 #include "base/strings/stringprintf.h" 12 #include "base/strings/stringprintf.h"
13 #include "base/strings/utf_string_conversions.h" 13 #include "base/strings/utf_string_conversions.h"
14 #include "base/sys_info.h" 14 #include "base/sys_info.h"
15 #include "chrome/browser/browser_process.h" 15 #include "chrome/browser/browser_process.h"
16 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h" 16 #include "chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h"
17 #include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h" 17 #include "chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.h"
18 #include "chrome/browser/chromeos/settings/cros_settings.h" 18 #include "chrome/browser/chromeos/settings/cros_settings.h"
19 #include "chrome/common/chrome_version_info.h" 19 #include "chrome/common/chrome_version_info.h"
20 #include "chrome/grit/chromium_strings.h" 20 #include "chrome/grit/chromium_strings.h"
21 #include "chrome/grit/generated_resources.h" 21 #include "chrome/grit/generated_resources.h"
22 #include "chromeos/settings/cros_settings_names.h" 22 #include "chromeos/settings/cros_settings_names.h"
23 #include "ui/base/l10n/l10n_util.h" 23 #include "ui/base/l10n/l10n_util.h"
24 24
25 namespace chromeos { 25 namespace chromeos {
26 26
27 namespace { 27 namespace {
28 28
29 const char* kReportingFlags[] = { 29 const char* const kReportingFlags[] = {
30 chromeos::kReportDeviceVersionInfo, 30 chromeos::kReportDeviceVersionInfo,
31 chromeos::kReportDeviceActivityTimes, 31 chromeos::kReportDeviceActivityTimes,
32 chromeos::kReportDeviceBootMode, 32 chromeos::kReportDeviceBootMode,
33 chromeos::kReportDeviceLocation, 33 chromeos::kReportDeviceLocation,
34 }; 34 };
35 35
36 // Strings used to generate the serial number part of the version string. 36 // Strings used to generate the serial number part of the version string.
37 const char kSerialNumberPrefix[] = "SN:"; 37 const char kSerialNumberPrefix[] = "SN:";
38 38
39 } // namespace 39 } // namespace
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
145 145
146 void VersionInfoUpdater::OnStoreLoaded(policy::CloudPolicyStore* store) { 146 void VersionInfoUpdater::OnStoreLoaded(policy::CloudPolicyStore* store) {
147 UpdateEnterpriseInfo(); 147 UpdateEnterpriseInfo();
148 } 148 }
149 149
150 void VersionInfoUpdater::OnStoreError(policy::CloudPolicyStore* store) { 150 void VersionInfoUpdater::OnStoreError(policy::CloudPolicyStore* store) {
151 UpdateEnterpriseInfo(); 151 UpdateEnterpriseInfo();
152 } 152 }
153 153
154 } // namespace chromeos 154 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698