chrome/browser/extensions/api/sessions/sessions_apitest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/sessions/sessions_apitest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/proxy/proxy_api_constants.cc ('k') | chrome/browser/extensions/api/socket/udp_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/sessions/sessions_apitest.cc

diff --git a/chrome/browser/extensions/api/sessions/sessions_apitest.cc b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

index 6182c14874ba01d8cd6f0c39caf202f548eb1a0d..cccb65359885ea7b790fe22884db8399774574cc 100644

--- a/chrome/browser/extensions/api/sessions/sessions_apitest.cc

+++ b/chrome/browser/extensions/api/sessions/sessions_apitest.cc

@@ -39,7 +39,7 @@ namespace {

// Fake session tabs (used to construct arbitrary device info) and tab IDs

// (used to construct arbitrary tab info) to use in all tests.

-const char* kSessionTags[] = {"tag0", "tag1", "tag2", "tag3", "tag4"};

+const char* const kSessionTags[] = {"tag0", "tag1", "tag2", "tag3", "tag4"};

const SessionID::id_type kTabIDs[] = {5, 10, 13, 17};

void BuildSessionSpecifics(const std::string& tag,

@@ -102,10 +102,10 @@ class ExtensionSessionsTest : public InProcessBrowserTest {

fn->set_extension(extension_.get());

fn->set_has_callback(has_callback);

return fn;

- };

+ }

Browser* browser_;

- scoped_refptr<extensions::Extension> extension_;

+ scoped_refptr<Extension> extension_;

};

void ExtensionSessionsTest::SetUpCommandLine(CommandLine* command_line) {