chrome/browser/chromeos/settings/device_settings_provider.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/settings/device_settings_provider.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/proxy_config_service_impl_unittest.cc ('k') | chrome/browser/extensions/active_script_controller_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/settings/device_settings_provider.cc

diff --git a/chrome/browser/chromeos/settings/device_settings_provider.cc b/chrome/browser/chromeos/settings/device_settings_provider.cc

index a6a4ae10283e1a006f085cc9923ed3527f107960..a3dcfe905facb6b0125d7b4d07e7f84291f6c024 100644

--- a/chrome/browser/chromeos/settings/device_settings_provider.cc

+++ b/chrome/browser/chromeos/settings/device_settings_provider.cc

@@ -37,7 +37,7 @@ namespace chromeos {

namespace {

// List of settings handled by the DeviceSettingsProvider.

-const char* kKnownSettings[] = {

+const char* const kKnownSettings[] = {

kAccountsPrefAllowGuest,

kAccountsPrefAllowNewUser,

kAccountsPrefDeviceLocalAccounts,

@@ -462,7 +462,7 @@ DeviceSettingsProvider::~DeviceSettingsProvider() {

// static

bool DeviceSettingsProvider::IsDeviceSetting(const std::string& name) {

- const char** end = kKnownSettings + arraysize(kKnownSettings);

+ const char* const* end = kKnownSettings + arraysize(kKnownSettings);

return std::find(kKnownSettings, end, name) != end;

}