chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/net/network_portal_detector_impl_browsertest.cc ('k') | chrome/browser/chromeos/net/network_portal_notification_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

diff --git a/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc b/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

index f692f13ce05fad0a0f88bcec898f4c81b6a1ebf1..235a4e66fea21f7237a4aa6882bde91a94c375d9 100644

--- a/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

+++ b/chrome/browser/chromeos/net/network_portal_detector_impl_unittest.cc

@@ -528,7 +528,7 @@ TEST_F(NetworkPortalDetectorImplTest, PortalDetectionTimeout) {

TEST_F(NetworkPortalDetectorImplTest, PortalDetectionRetryAfter) {

ASSERT_TRUE(is_state_idle());

- const char* retry_after = "HTTP/1.1 503 OK\nRetry-After: 101\n\n";

+ const char retry_after[] = "HTTP/1.1 503 OK\nRetry-After: 101\n\n";

ASSERT_TRUE(is_state_idle());

ASSERT_EQ(0, no_response_result_count());

@@ -549,7 +549,7 @@ TEST_F(NetworkPortalDetectorImplTest, PortalDetectionRetryAfter) {

TEST_F(NetworkPortalDetectorImplTest, PortalDetectorRetryAfterIsSmall) {

ASSERT_TRUE(is_state_idle());

- const char* retry_after = "HTTP/1.1 503 OK\nRetry-After: 1\n\n";

+ const char retry_after[] = "HTTP/1.1 503 OK\nRetry-After: 1\n\n";

ASSERT_TRUE(is_state_idle());

ASSERT_EQ(0, no_response_result_count());

@@ -570,7 +570,7 @@ TEST_F(NetworkPortalDetectorImplTest, FirstAttemptFailed) {

ASSERT_TRUE(is_state_idle());

set_delay_till_next_attempt(base::TimeDelta());

- const char* retry_after = "HTTP/1.1 503 OK\nRetry-After: 0\n\n";

+ const char retry_after[] = "HTTP/1.1 503 OK\nRetry-After: 0\n\n";

ASSERT_TRUE(is_state_idle());

ASSERT_EQ(0, no_response_result_count());

@@ -601,7 +601,7 @@ TEST_F(NetworkPortalDetectorImplTest, AllAttemptsFailed) {

ASSERT_TRUE(is_state_idle());

set_delay_till_next_attempt(base::TimeDelta());

- const char* retry_after = "HTTP/1.1 503 OK\nRetry-After: 0\n\n";

+ const char retry_after[] = "HTTP/1.1 503 OK\nRetry-After: 0\n\n";

ASSERT_TRUE(is_state_idle());

ASSERT_EQ(0, no_response_result_count());