chrome/browser/extensions/api/management/management_api_browsertest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_api_browsertest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | chrome/browser/extensions/api/management/management_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_api_browsertest.cc

diff --git a/chrome/browser/extensions/api/management/management_api_browsertest.cc b/chrome/browser/extensions/api/management/management_api_browsertest.cc

index ebf98958dbe22d25e02b1afd3e91e2ab0549c3d8..86a7bc7943c4a0581c42ea0d2b17432668c7441b 100644

--- a/chrome/browser/extensions/api/management/management_api_browsertest.cc

+++ b/chrome/browser/extensions/api/management/management_api_browsertest.cc

@@ -249,7 +249,7 @@ class ExtensionManagementApiEscalationTest :

const std::string& expected_error) {

scoped_refptr<ManagementSetEnabledFunction> function(

new ManagementSetEnabledFunction);

- const char* enabled_string = enabled ? "true" : "false";

+ const char* const enabled_string = enabled ? "true" : "false";

if (user_gesture)

function->set_user_gesture(true);

bool response = util::RunFunction(