chrome/browser/extensions/api/socket/udp_socket_unittest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/udp_socket_unittest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/sessions/sessions_apitest.cc ('k') | chrome/browser/extensions/api/system_private/system_private_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/socket/udp_socket_unittest.cc

diff --git a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc b/chrome/browser/extensions/api/socket/udp_socket_unittest.cc

index 48a51ac8a732dea61c874cd7e4ccb8eb70d4b97c..d9c4993add60c9b3da9c802b3ebc68815cda8dbb 100644

--- a/chrome/browser/extensions/api/socket/udp_socket_unittest.cc

+++ b/chrome/browser/extensions/api/socket/udp_socket_unittest.cc

@@ -50,7 +50,7 @@ TEST(UDPSocketUnitTest, TestUDPSocketRecvFrom) {

}

TEST(UDPSocketUnitTest, TestUDPMulticastJoinGroup) {

- const char* kGroup = "237.132.100.17";

+ const char kGroup[] = "237.132.100.17";

UDPSocket src("abcdefghijklmnopqrst");

UDPSocket dest("abcdefghijklmnopqrst");

@@ -66,7 +66,7 @@ TEST(UDPSocketUnitTest, TestUDPMulticastJoinGroup) {

}

TEST(UDPSocketUnitTest, TestUDPMulticastTimeToLive) {

- const char* kGroup = "237.132.100.17";

+ const char kGroup[] = "237.132.100.17";

UDPSocket socket("abcdefghijklmnopqrst");

EXPECT_NE(0, socket.SetMulticastTimeToLive(-1)); // Negative TTL shall fail.

EXPECT_EQ(0, socket.SetMulticastTimeToLive(3));

@@ -74,7 +74,7 @@ TEST(UDPSocketUnitTest, TestUDPMulticastTimeToLive) {

}

TEST(UDPSocketUnitTest, TestUDPMulticastLoopbackMode) {

- const char* kGroup = "237.132.100.17";

+ const char kGroup[] = "237.132.100.17";

UDPSocket socket("abcdefghijklmnopqrst");

EXPECT_EQ(0, socket.SetMulticastLoopbackMode(false));

socket.Connect(kGroup, 13333, base::Bind(&OnConnected));

@@ -110,7 +110,7 @@ static void OnMulticastReadCompleted(bool *packet_received,

TEST(UDPSocketUnitTest, TestUDPMulticastRecv) {

const int kPort = 9999;

- const char* const kGroup = "237.132.100.17";

+ const char kGroup[] = "237.132.100.17";

bool packet_received = false;

base::MessageLoopForIO io_loop; // For Read to do its threaded work.

UDPSocket dest("abcdefghijklmnopqrst");