chrome/browser/extensions/activity_log/hashed_ad_network_database.h - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/hashed_ad_network_database.h

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/generate_ad_network_hashes.py ('k') | chrome/browser/extensions/activity_log/hashed_ad_network_database_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/hashed_ad_network_database.h

diff --git a/chrome/browser/extensions/activity_log/hashed_ad_network_database.h b/chrome/browser/extensions/activity_log/hashed_ad_network_database.h

index a281bd902952f2e6011a213a8a0365800328af2f..dae2eeeb13413c6c63988c0f91c41d03efb78aee 100644

--- a/chrome/browser/extensions/activity_log/hashed_ad_network_database.h

+++ b/chrome/browser/extensions/activity_log/hashed_ad_network_database.h

@@ -16,7 +16,7 @@ class HashedAdNetworkDatabase : public AdNetworkDatabase {

HashedAdNetworkDatabase();

~HashedAdNetworkDatabase() override;

- void set_entries_for_testing(const char** entries, int num_entries) {

+ void set_entries_for_testing(const char* const* entries, int num_entries) {

entries_ = entries;

num_entries_ = num_entries;

}

@@ -27,7 +27,7 @@ class HashedAdNetworkDatabase : public AdNetworkDatabase {

// Points to the array of hash entries. In practice, this is always set to

// kHashedAdNetworks, but is exposed via set_entries_for_testing().

- const char** entries_;

+ const char* const* entries_;

// The number of entries.

int num_entries_;