Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1677)

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api_constants.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/proxy/proxy_api_constants.cc
diff --git a/chrome/browser/extensions/api/proxy/proxy_api_constants.cc b/chrome/browser/extensions/api/proxy/proxy_api_constants.cc
index df2c8bb00b9648602ec7ce6d059d1f73a7ff90ad..3142b2f75894135d58fa95c8b31c228fa0b91c16 100644
--- a/chrome/browser/extensions/api/proxy/proxy_api_constants.cc
+++ b/chrome/browser/extensions/api/proxy/proxy_api_constants.cc
@@ -30,17 +30,17 @@ const char kProxyEventOnProxyError[] = "proxy.onProxyError";
const char kPACDataUrlPrefix[] =
"data:application/x-ns-proxy-autoconfig;base64,";
-const char* field_name[] = { "singleProxy",
- "proxyForHttp",
- "proxyForHttps",
- "proxyForFtp",
- "fallbackProxy" };
-
-const char* scheme_name[] = { "*error*",
- "http",
- "https",
- "ftp",
- "socks" };
+const char* const field_name[] = { "singleProxy",
+ "proxyForHttp",
+ "proxyForHttps",
+ "proxyForFtp",
+ "fallbackProxy" };
+
+const char* const scheme_name[] = { "*error*",
+ "http",
+ "https",
+ "ftp",
+ "socks" };
COMPILE_ASSERT(SCHEME_MAX == SCHEME_FALLBACK,
SCHEME_MAX_must_equal_SCHEME_FALLBACK);
@@ -51,4 +51,4 @@ COMPILE_ASSERT(arraysize(scheme_name) == SCHEME_MAX + 1,
COMPILE_ASSERT(SCHEME_ALL == 0, singleProxy_must_be_first_option);
} // namespace proxy_api_constants
-} // extensions
+} // namespace extensions
« no previous file with comments | « chrome/browser/extensions/api/proxy/proxy_api_constants.h ('k') | chrome/browser/extensions/api/sessions/sessions_apitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698