chrome/browser/extensions/activity_log/activity_database_unittest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_database_unittest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_database.cc ('k') | chrome/browser/extensions/activity_log/activity_log_enabled_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_database_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/activity_database_unittest.cc b/chrome/browser/extensions/activity_log/activity_database_unittest.cc

index 4bef42b54bd0b026025a462ab6d267411ce23529..da4bc2e7dba3007982c8732cd10aba2c4619487f 100644

--- a/chrome/browser/extensions/activity_log/activity_database_unittest.cc

+++ b/chrome/browser/extensions/activity_log/activity_database_unittest.cc

@@ -44,11 +44,11 @@ namespace extensions {

// the unit tests.

class ActivityDatabaseTestPolicy : public ActivityDatabase::Delegate {

public:

- ActivityDatabaseTestPolicy() {};

+ ActivityDatabaseTestPolicy() {}

static const char kTableName[];

- static const char* kTableContentFields[];

- static const char* kTableFieldTypes[];

+ static const char* const kTableContentFields[];

+ static const char* const kTableFieldTypes[];

virtual void Record(ActivityDatabase* db, scoped_refptr<Action> action);

@@ -62,9 +62,9 @@ class ActivityDatabaseTestPolicy : public ActivityDatabase::Delegate {

};

const char ActivityDatabaseTestPolicy::kTableName[] = "actions";

-const char* ActivityDatabaseTestPolicy::kTableContentFields[] = {

+const char* const ActivityDatabaseTestPolicy::kTableContentFields[] = {

"extension_id", "time", "action_type", "api_name"};

-const char* ActivityDatabaseTestPolicy::kTableFieldTypes[] = {

+const char* const ActivityDatabaseTestPolicy::kTableFieldTypes[] = {

"LONGVARCHAR NOT NULL", "INTEGER", "INTEGER", "LONGVARCHAR"};

bool ActivityDatabaseTestPolicy::InitDatabase(sql::Connection* db) {