chrome/browser/extensions/api/management/management_browsertest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/management/management_browsertest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/management/management_api_browsertest.cc ('k') | chrome/browser/extensions/api/music_manager_private/device_id_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/management/management_browsertest.cc

diff --git a/chrome/browser/extensions/api/management/management_browsertest.cc b/chrome/browser/extensions/api/management/management_browsertest.cc

index 9140b0c941697e6c8ebe7c6d0d55b62feb72e006..0ebb0125634800074b367df2eb2a1a38f532dec1 100644

--- a/chrome/browser/extensions/api/management/management_browsertest.cc

+++ b/chrome/browser/extensions/api/management/management_browsertest.cc

@@ -437,7 +437,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,

IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalUrlUpdate) {

ExtensionService* service = extensions::ExtensionSystem::Get(

browser()->profile())->extension_service();

- const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";

+ const char kExtensionId[] = "ogjcoiohnmldgjemafoockdghcjciccf";

extensions::ExtensionUpdater::CheckParams params;

base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");

@@ -522,7 +522,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalUrlUpdate) {

namespace {

-const char* kForceInstallNotEmptyHelp =

+const char kForceInstallNotEmptyHelp[] =

"A policy may already be controlling the list of force-installed "

"extensions. Please remove all policy settings from your computer "

"before running tests. E.g. from /etc/chromium/policies Linux or "

@@ -534,7 +534,7 @@ const char* kForceInstallNotEmptyHelp =

IN_PROC_BROWSER_TEST_F(ExtensionManagementTest, ExternalPolicyRefresh) {

ExtensionService* service = extensions::ExtensionSystem::Get(

browser()->profile())->extension_service();

- const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";

+ const char kExtensionId[] = "ogjcoiohnmldgjemafoockdghcjciccf";

base::FilePath basedir = test_data_dir_.AppendASCII("autoupdate");

@@ -615,7 +615,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionManagementTest,

ExtensionService* service = extensions::ExtensionSystem::Get(

browser()->profile())->extension_service();

ExtensionRegistry* registry = ExtensionRegistry::Get(browser()->profile());

- const char* kExtensionId = "ogjcoiohnmldgjemafoockdghcjciccf";

+ const char kExtensionId[] = "ogjcoiohnmldgjemafoockdghcjciccf";

extensions::ExtensionUpdater::CheckParams params;

service->updater()->set_default_check_params(params);

const size_t size_before = registry->enabled_extensions().size();