Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

chrome/browser/extensions/error_console/error_console_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/error_console/error_console.h"
 
 #include "base/files/file_path.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string16.h"
 #include "base/strings/stringprintf.h"
@@ skipping 17 matching lines @@
 
 using base::string16;
 using base::UTF8ToUTF16;
 
 namespace extensions {
 
 namespace {
 
 const char kTestingPage[] = "/extensions/test_file.html";
 const char kAnonymousFunction[] = "(anonymous function)";
-const char* kBackgroundPageName =
+const char* const kBackgroundPageName =
     extensions::kGeneratedBackgroundPageFilename;
 const int kNoFlags = 0;
 
 const StackTrace& GetStackTraceFromError(const ExtensionError* error) {
   CHECK(error->type() == ExtensionError::RUNTIME_ERROR);
   return (static_cast<const RuntimeError*>(error))->stack_trace();
 }
 
 // Verify that a given |frame| has the proper source and function name.
 void CheckStackFrame(const StackFrame& frame,
@@ skipping 218 matching lines @@
     // We should only have errors for a single extension, or should have no
     // entries, if no errors were expected.
     ASSERT_EQ(errors_expected > 0 ? 1u : 0u,
               error_console()->get_num_entries_for_test());
     ASSERT_EQ(
         errors_expected,
         error_console()->GetErrorsForExtension((*extension)->id()).size());
   }
 
   ErrorConsole* error_console() { return error_console_; }
+
  private:
   // The URL used in testing for simple page navigations.
   GURL test_url_;
 
   // Weak reference to the ErrorConsole.
   ErrorConsole* error_console_;
 };
 
 // Test to ensure that we are successfully reporting manifest errors as an
 // extension is installed.
@@ skipping 97 matching lines @@
                     "Hello, World!",  // The error message is the log.
                     logging::LOG_INFO,
                     GetTestURL(),  // Content scripts run in the web page.
                     2u);
 
   const StackTrace& stack_trace1 = GetStackTraceFromError(errors[0]);
   CheckStackFrame(stack_trace1[0],
                   script_url,
                   "logHelloWorld",  // function name
                   6u,  // line number
-                  11u /* column number */ );
+                  11u /* column number */);
 
   CheckStackFrame(stack_trace1[1],
                   script_url,
                   kAnonymousFunction,
                   9u,
                   1u);
 
   // The second error should be a runtime error.
   CheckRuntimeError(errors[1],
                     extension->id(),
@@ skipping 168 matching lines @@
 
   const StackTrace& stack_trace = GetStackTraceFromError(errors[0]);
   ASSERT_EQ(1u, stack_trace.size());
   CheckStackFrame(stack_trace[0],
                   script_url,
                   kAnonymousFunction,
                   12u, 20u);
 }
 
 }  // namespace extensions