chrome/browser/extensions/extension_keybinding_apitest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_keybinding_apitest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_disabled_ui_browsertest.cc ('k') | chrome/browser/extensions/extension_loading_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_keybinding_apitest.cc

diff --git a/chrome/browser/extensions/extension_keybinding_apitest.cc b/chrome/browser/extensions/extension_keybinding_apitest.cc

index 66755bbae3f09acbb5ad0eb875742679076631c3..29c93a7d8d6152b408f85c03cebf46b6fc1c1256 100644

--- a/chrome/browser/extensions/extension_keybinding_apitest.cc

+++ b/chrome/browser/extensions/extension_keybinding_apitest.cc

@@ -377,9 +377,9 @@ IN_PROC_BROWSER_TEST_F(CommandsApiTest,

const Extension* extension = GetSingleLoadedExtension();

// Simulate the user setting the keybinding to Ctrl+D.

#if defined(OS_MACOSX)

- const char* hotkey = "Command+D";

+ const char hotkey[] = "Command+D";

#else

- const char* hotkey = "Ctrl+D";

+ const char hotkey[] = "Ctrl+D";

#endif // defined(OS_MACOSX)

command_service->UpdateKeybindingPrefs(

extension->id(), manifest_values::kBrowserActionCommandEvent, hotkey);