Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Unified Diff: chrome/browser/extensions/extension_messages_apitest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_messages_apitest.cc
diff --git a/chrome/browser/extensions/extension_messages_apitest.cc b/chrome/browser/extensions/extension_messages_apitest.cc
index d727ada9fbef85bd7f26db918215bbe34b6ba730..cae566754409719c5a22e423d32be347735ba9f2 100644
--- a/chrome/browser/extensions/extension_messages_apitest.cc
+++ b/chrome/browser/extensions/extension_messages_apitest.cc
@@ -213,7 +213,7 @@ class ExternallyConnectableMessagingTest : public ExtensionApiTest {
testing::AssertionResult AreAnyNonWebApisDefinedForFrame(
content::RenderFrameHost* frame) {
// All runtime API methods are non-web except for sendRequest and connect.
- const char* non_messaging_apis[] = {
+ const char* const non_messaging_apis[] = {
"getBackgroundPage",
"getManifest",
"getURL",
@@ -622,7 +622,7 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingTest,
// previously closed.
tls_channel_id =
GetTlsChannelIdFromPortConnect(chromium_connectable.get(), true);
- // And the empty value is still retrieved.
+ // And the empty value is still retrieved.
EXPECT_EQ(std::string(), tls_channel_id);
}
@@ -987,7 +987,7 @@ IN_PROC_BROWSER_TEST_F(ExternallyConnectableMessagingWithTlsChannelIdTest,
// previously closed.
tls_channel_id =
GetTlsChannelIdFromPortConnect(chromium_connectable.get(), true);
- // And the expected value is still retrieved.
+ // And the expected value is still retrieved.
EXPECT_EQ(expected_tls_channel_id_value, tls_channel_id);
}
« no previous file with comments | « chrome/browser/extensions/extension_loading_browsertest.cc ('k') | chrome/browser/extensions/extension_nacl_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698