chrome/browser/extensions/external_component_loader.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_component_loader.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_warning_badge_service_unittest.cc ('k') | chrome/browser/extensions/hotword_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/external_component_loader.cc

diff --git a/chrome/browser/extensions/external_component_loader.cc b/chrome/browser/extensions/external_component_loader.cc

index 84f629fc9e3065854b68da16ced625c9b300a7da..f6379a295816113ece4f7f568a134faae899aa11 100644

--- a/chrome/browser/extensions/external_component_loader.cc

+++ b/chrome/browser/extensions/external_component_loader.cc

@@ -32,7 +32,7 @@ ExternalComponentLoader::~ExternalComponentLoader() {}

// static

bool ExternalComponentLoader::IsModifiable(const Extension* extension) {

if (extension->location() == Manifest::EXTERNAL_COMPONENT) {

- static const char* enhanced_extension_hashes[] = {

+ static const char* const enhanced_extension_hashes[] = {

"D5736E4B5CF695CB93A2FB57E4FDC6E5AFAB6FE2", // http://crbug.com/312900

"D57DE394F36DC1C3220E7604C575D29C51A6C495", // http://crbug.com/319444

"3F65507A3B39259B38C8173C6FFA3D12DF64CCE9" // http://crbug.com/371562