Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

chrome/browser/extensions/api/socket/udp_socket_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/browser/api/socket/udp_socket.h"
 
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 32 matching lines @@
   UDPSocket socket("abcdefghijklmnopqrst");
 
   // Confirm that we can call two RecvFroms in quick succession without
   // triggering crbug.com/146606.
   socket.Connect("127.0.0.1", 40000, base::Bind(&OnConnected));
   socket.RecvFrom(4096, base::Bind(&OnCompleted));
   socket.RecvFrom(4096, base::Bind(&OnCompleted));
 }
 
 TEST(UDPSocketUnitTest, TestUDPMulticastJoinGroup) {
-  const char* kGroup = "237.132.100.17";
+  const char kGroup[] = "237.132.100.17";
   UDPSocket src("abcdefghijklmnopqrst");
   UDPSocket dest("abcdefghijklmnopqrst");
 
   EXPECT_EQ(0, dest.Bind("0.0.0.0", 13333));
   EXPECT_EQ(0, dest.JoinGroup(kGroup));
   std::vector<std::string> groups = dest.GetJoinedGroups();
   EXPECT_EQ(static_cast<size_t>(1), groups.size());
   EXPECT_EQ(kGroup, *groups.begin());
   EXPECT_NE(0, dest.LeaveGroup("237.132.100.13"));
   EXPECT_EQ(0, dest.LeaveGroup(kGroup));
   groups = dest.GetJoinedGroups();
   EXPECT_EQ(static_cast<size_t>(0), groups.size());
 }
 
 TEST(UDPSocketUnitTest, TestUDPMulticastTimeToLive) {
-  const char* kGroup = "237.132.100.17";
+  const char kGroup[] = "237.132.100.17";
   UDPSocket socket("abcdefghijklmnopqrst");
   EXPECT_NE(0, socket.SetMulticastTimeToLive(-1));  // Negative TTL shall fail.
   EXPECT_EQ(0, socket.SetMulticastTimeToLive(3));
   socket.Connect(kGroup, 13333, base::Bind(&OnConnected));
 }
 
 TEST(UDPSocketUnitTest, TestUDPMulticastLoopbackMode) {
-  const char* kGroup = "237.132.100.17";
+  const char kGroup[] = "237.132.100.17";
   UDPSocket socket("abcdefghijklmnopqrst");
   EXPECT_EQ(0, socket.SetMulticastLoopbackMode(false));
   socket.Connect(kGroup, 13333, base::Bind(&OnConnected));
 }
 
 static void QuitMessageLoop() {
   base::MessageLoopForIO::current()->QuitNow();
 }
 
 // Send a test multicast packet every second.
@@ skipping 15 matching lines @@
                                      int count,
                                      scoped_refptr<net::IOBuffer> io_buffer) {
   EXPECT_EQ(test_message_length, count);
   EXPECT_EQ(0, strncmp(io_buffer->data(), test_message, test_message_length));
   *packet_received = true;
   QuitMessageLoop();
 }
 
 TEST(UDPSocketUnitTest, TestUDPMulticastRecv) {
   const int kPort = 9999;
-  const char* const kGroup = "237.132.100.17";
+  const char kGroup[] = "237.132.100.17";
   bool packet_received = false;
   base::MessageLoopForIO io_loop;  // For Read to do its threaded work.
   UDPSocket dest("abcdefghijklmnopqrst");
   UDPSocket src("abcdefghijklmnopqrst");
 
   // Receiver
   EXPECT_EQ(0, dest.Bind("0.0.0.0", kPort));
   EXPECT_EQ(0, dest.JoinGroup(kGroup));
   dest.Read(1024, base::Bind(&OnMulticastReadCompleted, &packet_received));
 
   // Sender
   EXPECT_EQ(0, src.SetMulticastTimeToLive(0));
   src.Connect(kGroup, kPort, base::Bind(&SendMulticastPacket, &src));
 
   // If not received within the test action timeout, quit the message loop.
   io_loop.PostDelayedTask(FROM_HERE,
                           base::Bind(&QuitMessageLoop),
                           TestTimeouts::action_timeout());
 
   io_loop.Run();
 
   EXPECT_TRUE(packet_received) << "Failed to receive from multicast address";
 }
 
 }  // namespace extensions