Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4045)

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/browser/extensions/default_apps.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/crx_installer.cc
diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc
index 731c8ef9a36f9041657b7617280a7997e66cf287..d9cf9ca2836257d257b2b78d7258cd80c8097328 100644
--- a/chrome/browser/extensions/crx_installer.cc
+++ b/chrome/browser/extensions/crx_installer.cc
@@ -330,7 +330,7 @@ CrxInstallerError CrxInstaller::AllowInstall(const Extension* extension) {
if (install_cause_ == extension_misc::INSTALL_CAUSE_USER_DOWNLOAD) {
if (FeatureSwitch::easy_off_store_install()->IsEnabled()) {
- const char* kHistogramName = "Extensions.OffStoreInstallDecisionEasy";
+ const char kHistogramName[] = "Extensions.OffStoreInstallDecisionEasy";
if (is_gallery_install()) {
UMA_HISTOGRAM_ENUMERATION(kHistogramName, OnStoreInstall,
NumOffStoreInstallDecision);
@@ -339,7 +339,7 @@ CrxInstallerError CrxInstaller::AllowInstall(const Extension* extension) {
NumOffStoreInstallDecision);
}
} else {
- const char* kHistogramName = "Extensions.OffStoreInstallDecisionHard";
+ const char kHistogramName[] = "Extensions.OffStoreInstallDecisionHard";
if (is_gallery_install()) {
UMA_HISTOGRAM_ENUMERATION(kHistogramName, OnStoreInstall,
NumOffStoreInstallDecision);
« no previous file with comments | « chrome/browser/extensions/content_script_apitest.cc ('k') | chrome/browser/extensions/default_apps.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698