Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Side by Side Diff: chrome/browser/chromeos/extensions/default_app_order.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/extensions/default_app_order.h" 5 #include "chrome/browser/chromeos/extensions/default_app_order.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 13 matching lines...) Expand all
24 // The single ExternalLoader instance. 24 // The single ExternalLoader instance.
25 ExternalLoader* loader_instance = NULL; 25 ExternalLoader* loader_instance = NULL;
26 26
27 // Names used in JSON file. 27 // Names used in JSON file.
28 const char kOemAppsFolderAttr[] = "oem_apps_folder"; 28 const char kOemAppsFolderAttr[] = "oem_apps_folder";
29 const char kLocalizedContentAttr[] = "localized_content"; 29 const char kLocalizedContentAttr[] = "localized_content";
30 const char kDefaultAttr[] = "default"; 30 const char kDefaultAttr[] = "default";
31 const char kNameAttr[] = "name"; 31 const char kNameAttr[] = "name";
32 const char kImportDefaultOrderAttr[] = "import_default_order"; 32 const char kImportDefaultOrderAttr[] = "import_default_order";
33 33
34 const char* kDefaultAppOrder[] = { 34 const char* const kDefaultAppOrder[] = {
35 extension_misc::kChromeAppId, 35 extension_misc::kChromeAppId,
36 extensions::kWebStoreAppId, 36 extensions::kWebStoreAppId,
37 extension_misc::kGoogleSearchAppId, 37 extension_misc::kGoogleSearchAppId,
38 extension_misc::kYoutubeAppId, 38 extension_misc::kYoutubeAppId,
39 extension_misc::kGmailAppId, 39 extension_misc::kGmailAppId,
40 "ejjicmeblgpmajnghnpcppodonldlgfn", // Calendar 40 "ejjicmeblgpmajnghnpcppodonldlgfn", // Calendar
41 "kjebfhglflhjjjiceimfkgicifkhjlnm", // Scratchpad 41 "kjebfhglflhjjjiceimfkgicifkhjlnm", // Scratchpad
42 "lneaknkopdijkpnocmklfnjbeapigfbh", // Google Maps 42 "lneaknkopdijkpnocmklfnjbeapigfbh", // Google Maps
43 "apdfllckaahabafndbhieahigkjlhalf", // Drive 43 "apdfllckaahabafndbhieahigkjlhalf", // Drive
44 extension_misc::kGoogleDocAppId, 44 extension_misc::kGoogleDocAppId,
(...skipping 149 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 std::string GetOemAppsFolderName() { 194 std::string GetOemAppsFolderName() {
195 // |loader_instance| could be NULL for test. 195 // |loader_instance| could be NULL for test.
196 if (!loader_instance) 196 if (!loader_instance)
197 return std::string(); 197 return std::string();
198 else 198 else
199 return loader_instance->GetOemAppsFolderName(); 199 return loader_instance->GetOemAppsFolderName();
200 } 200 }
201 201
202 } // namespace default_app_order 202 } // namespace default_app_order
203 } // namespace chromeos 203 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698