chrome/browser/chromeos/login/oobe_localization_browsertest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/oobe_localization_browsertest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/chrome_restart_request.cc ('k') | chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/oobe_localization_browsertest.cc

diff --git a/chrome/browser/chromeos/login/oobe_localization_browsertest.cc b/chrome/browser/chromeos/login/oobe_localization_browsertest.cc

index 69c60b6da780dcec1c26fc8919e9ff33f4aac1d8..9ba1947dee049e16df6d2882c7d3a82f9de48c1d 100644

--- a/chrome/browser/chromeos/login/oobe_localization_browsertest.cc

+++ b/chrome/browser/chromeos/login/oobe_localization_browsertest.cc

@@ -35,10 +35,10 @@ namespace chromeos {

namespace {

// OOBE constants.

-const char* kLocaleSelect = "language-select";

-const char* kKeyboardSelect = "keyboard-select";

+const char kLocaleSelect[] = "language-select";

+const char kKeyboardSelect[] = "keyboard-select";

-const char* kUSLayout = "xkb:us::eng";

+const char kUSLayout[] = "xkb:us::eng";

}