Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: chrome/browser/extensions/api/alarms/alarms_api_unittest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/alarms/alarms_api_unittest.cc
diff --git a/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc b/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc
index 509fde23c5a29ada68f0cf56027ae661e724a74d..c5f4e836f5a116c2f26f4c250fcff478574d9d7a 100644
--- a/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc
+++ b/chrome/browser/extensions/api/alarms/alarms_api_unittest.cc
@@ -89,9 +89,9 @@ class ExtensionAlarmsTest : public ExtensionApiUnittest {
// Creates up to 3 alarms using the extension API.
void CreateAlarms(size_t num_alarms) {
- CHECK(num_alarms <= 3);
+ CHECK_LE(num_alarms, 3U);
- const char* kCreateArgs[] = {
+ const char* const kCreateArgs[] = {
"[null, {\"periodInMinutes\": 0.001}]",
"[\"7\", {\"periodInMinutes\": 7}]",
"[\"0\", {\"delayInMinutes\": 0}]",
@@ -460,8 +460,9 @@ class ExtensionAlarmsSchedulingTest : public ExtensionAlarmsTest {
EXPECT_EQ(scheduled_time, alarm_manager_->next_poll_time_);
}
- static void RemoveAlarmCallback (bool success) { EXPECT_TRUE(success); }
- static void RemoveAllAlarmsCallback () {}
+ static void RemoveAlarmCallback(bool success) { EXPECT_TRUE(success); }
+ static void RemoveAllAlarmsCallback() {}
+
public:
// Get the time that the alarm named is scheduled to run.
void VerifyScheduledTime(const std::string& alarm_name) {
@@ -477,7 +478,7 @@ class ExtensionAlarmsSchedulingTest : public ExtensionAlarmsTest {
base::Bind(&ExtensionAlarmsSchedulingTest::RemoveAlarmCallback));
}
- void RemoveAllAlarms () {
+ void RemoveAllAlarms() {
alarm_manager_->RemoveAllAlarms(extension()->id(), base::Bind(
&ExtensionAlarmsSchedulingTest::RemoveAllAlarmsCallback));
}

Powered by Google App Engine
This is Rietveld 408576698