Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Side by Side Diff: chrome/browser/extensions/activity_log/activity_actions.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/activity_log/activity_actions.h" 5 #include "chrome/browser/extensions/activity_log/activity_actions.h"
6 6
7 #include <algorithm> // for std::find. 7 #include <algorithm> // for std::find.
8 #include <string> 8 #include <string>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 20 matching lines...) Expand all
31 #include "url/gurl.h" 31 #include "url/gurl.h"
32 32
33 namespace constants = activity_log_constants; 33 namespace constants = activity_log_constants;
34 34
35 namespace extensions { 35 namespace extensions {
36 36
37 namespace { 37 namespace {
38 38
39 // The "Extensions.PossibleAdInjection2" metric uses different Rappor 39 // The "Extensions.PossibleAdInjection2" metric uses different Rappor
40 // parameters than the original metric. 40 // parameters than the original metric.
41 const char* kExtensionAdInjectionRapporMetricName = 41 const char kExtensionAdInjectionRapporMetricName[] =
42 "Extensions.PossibleAdInjection2"; 42 "Extensions.PossibleAdInjection2";
43 43
44 const char kBlinkSetAttributeEvent[] = "blinkSetAttribute"; 44 const char kBlinkSetAttributeEvent[] = "blinkSetAttribute";
45 const char kBlinkAddElementEvent[] = "blinkAddElement"; 45 const char kBlinkAddElementEvent[] = "blinkAddElement";
46 46
47 const char kIframe[] = "iframe"; 47 const char kIframe[] = "iframe";
48 const char kAnchor[] = "a"; 48 const char kAnchor[] = "a";
49 const char kScript[] = "script"; 49 const char kScript[] = "script";
50 50
51 const char kSrc[] = "src"; 51 const char kSrc[] = "src";
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
545 std::string rhs_other = ActivityLogPolicy::Util::Serialize(rhs->other()); 545 std::string rhs_other = ActivityLogPolicy::Util::Serialize(rhs->other());
546 if (lhs_other != rhs_other) 546 if (lhs_other != rhs_other)
547 return lhs_other < rhs_other; 547 return lhs_other < rhs_other;
548 } 548 }
549 549
550 // All fields compare as equal if this point is reached. 550 // All fields compare as equal if this point is reached.
551 return false; 551 return false;
552 } 552 }
553 553
554 } // namespace extensions 554 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698