chrome/browser/extensions/api/proxy/proxy_api_constants.h - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/api/proxy/proxy_api_constants.h

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/api/music_manager_private/device_id_linux.cc ('k') | chrome/browser/extensions/api/proxy/proxy_api_constants.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Constants for the Chrome Extensions Proxy Settings API.	5 // Constants for the Chrome Extensions Proxy Settings API.

6	6

7 #ifndef CHROME_BROWSER_EXTENSIONS_API_PROXY_PROXY_API_CONSTANTS_H_	7 #ifndef CHROME_BROWSER_EXTENSIONS_API_PROXY_PROXY_API_CONSTANTS_H_

8 #define CHROME_BROWSER_EXTENSIONS_API_PROXY_PROXY_API_CONSTANTS_H_	8 #define CHROME_BROWSER_EXTENSIONS_API_PROXY_PROXY_API_CONSTANTS_H_

9	9

10 namespace extensions {	10 namespace extensions {

(...skipping 25 matching lines...) Expand all Loading...
36 SCHEME_ALL = 0,	36 SCHEME_ALL = 0,

37 SCHEME_HTTP,	37 SCHEME_HTTP,

38 SCHEME_HTTPS,	38 SCHEME_HTTPS,

39 SCHEME_FTP,	39 SCHEME_FTP,

40 SCHEME_FALLBACK,	40 SCHEME_FALLBACK,

41 SCHEME_MAX = SCHEME_FALLBACK // Keep this value up to date.	41 SCHEME_MAX = SCHEME_FALLBACK // Keep this value up to date.

42 };	42 };

43	43

44 // The names of the JavaScript properties to extract from the proxy_rules.	44 // The names of the JavaScript properties to extract from the proxy_rules.

45 // These must be kept in sync with the SCHEME_* constants.	45 // These must be kept in sync with the SCHEME_* constants.

46 extern const char* field_name[];	46 extern const char* const field_name[];

47	47

48 // The names of the schemes to be used to build the preference value string	48 // The names of the schemes to be used to build the preference value string

49 // for manual proxy settings. These must be kept in sync with the SCHEME_*	49 // for manual proxy settings. These must be kept in sync with the SCHEME_*

50 // constants.	50 // constants.

51 extern const char* scheme_name[];	51 extern const char* const scheme_name[];

52	52

53 } // namespace proxy_api_constants	53 } // namespace proxy_api_constants

54 } // namespace extensions	54 } // namespace extensions

55	55

56 #endif // CHROME_BROWSER_EXTENSIONS_API_PROXY_PROXY_API_CONSTANTS_H_	56 #endif // CHROME_BROWSER_EXTENSIONS_API_PROXY_PROXY_API_CONSTANTS_H_

OLD	NEW