Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: chrome/browser/extensions/active_script_controller_browsertest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/active_script_controller_browsertest.cc
diff --git a/chrome/browser/extensions/active_script_controller_browsertest.cc b/chrome/browser/extensions/active_script_controller_browsertest.cc
index d282170b04960b14d3360fbf8a4c16e95f661448..eea16bd545bd3f20fb2a0587f606228fa71e2b9c 100644
--- a/chrome/browser/extensions/active_script_controller_browsertest.cc
+++ b/chrome/browser/extensions/active_script_controller_browsertest.cc
@@ -108,7 +108,7 @@ const Extension* ActiveScriptControllerBrowserTest::CreateExtension(
"content_script" : "execute_script",
host_type == ALL_HOSTS ? "all_hosts" : "explicit_hosts");
- const char* permission_scheme =
+ const char* const permission_scheme =
host_type == ALL_HOSTS ? kAllHostsScheme : kExplicitHostsScheme;
std::string permissions = base::StringPrintf(
@@ -303,7 +303,7 @@ IN_PROC_BROWSER_TEST_F(ActiveScriptControllerBrowserTest,
base::FilePath active_script_path =
test_data_dir_.AppendASCII("active_script");
- const char* kExtensionNames[] = {
+ const char* const kExtensionNames[] = {
"inject_scripts_all_hosts",
"inject_scripts_explicit_hosts",
"content_scripts_all_hosts",
@@ -415,7 +415,7 @@ class FlagOffActiveScriptControllerBrowserTest
IN_PROC_BROWSER_TEST_F(FlagOffActiveScriptControllerBrowserTest,
ScriptsExecuteWhenFlagAbsent) {
- const char* kExtensionNames[] = {
+ const char* const kExtensionNames[] = {
"content_scripts_all_hosts",
"inject_scripts_all_hosts",
};

Powered by Google App Engine
This is Rietveld 408576698