Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Side by Side Diff: chrome/browser/extensions/hotword_browsertest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase, nit Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/extensions/external_component_loader.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/files/file_path.h" 5 #include "base/files/file_path.h"
6 #include "base/path_service.h" 6 #include "base/path_service.h"
7 #include "base/prefs/pref_service.h" 7 #include "base/prefs/pref_service.h"
8 #include "chrome/browser/extensions/component_loader.h" 8 #include "chrome/browser/extensions/component_loader.h"
9 #include "chrome/browser/extensions/error_console/error_console.h" 9 #include "chrome/browser/extensions/error_console/error_console.h"
10 #include "chrome/browser/extensions/extension_browsertest.h" 10 #include "chrome/browser/extensions/extension_browsertest.h"
11 #include "chrome/browser/extensions/extension_service.h" 11 #include "chrome/browser/extensions/extension_service.h"
12 #include "chrome/browser/profiles/profile.h" 12 #include "chrome/browser/profiles/profile.h"
13 #include "chrome/common/pref_names.h" 13 #include "chrome/common/pref_names.h"
14 #include "chrome/test/base/ui_test_utils.h" 14 #include "chrome/test/base/ui_test_utils.h"
15 #include "content/public/common/content_switches.h" 15 #include "content/public/common/content_switches.h"
16 #include "extensions/common/extension.h" 16 #include "extensions/common/extension.h"
17 #include "extensions/test/extension_test_message_listener.h" 17 #include "extensions/test/extension_test_message_listener.h"
18 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
19 19
20 20
21 namespace extensions { 21 namespace extensions {
22 22
23 static const char* kHotwordHelperExtensionId = 23 static const char kHotwordHelperExtensionId[] =
24 "dnhpdliibojhegemfjheidglijccjfmc"; 24 "dnhpdliibojhegemfjheidglijccjfmc";
25 25
26 class HotwordBrowserTest : public ExtensionBrowserTest { 26 class HotwordBrowserTest : public ExtensionBrowserTest {
27 public: 27 public:
28 HotwordBrowserTest() : error_console_(NULL) { } 28 HotwordBrowserTest() : error_console_(NULL) { }
29 ~HotwordBrowserTest() override {} 29 ~HotwordBrowserTest() override {}
30 30
31 protected: 31 protected:
32 void SetUpInProcessBrowserTestFixture() override { 32 void SetUpInProcessBrowserTestFixture() override {
33 ExtensionBrowserTest::SetUpInProcessBrowserTestFixture(); 33 ExtensionBrowserTest::SetUpInProcessBrowserTestFixture();
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 ASSERT_TRUE(extension); 78 ASSERT_TRUE(extension);
79 const Extension* test_extension = LoadExtension( 79 const Extension* test_extension = LoadExtension(
80 test_data_dir_.AppendASCII("hotword")); 80 test_data_dir_.AppendASCII("hotword"));
81 ASSERT_TRUE(test_extension); 81 ASSERT_TRUE(test_extension);
82 82
83 ASSERT_TRUE(doneListener.WaitUntilSatisfied()); 83 ASSERT_TRUE(doneListener.WaitUntilSatisfied());
84 ASSERT_TRUE(error_console()->GetErrorsForExtension(extension->id()).empty()); 84 ASSERT_TRUE(error_console()->GetErrorsForExtension(extension->id()).empty());
85 } 85 }
86 86
87 } // namespace extensions 87 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/external_component_loader.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698