chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/oobe_localization_browsertest.cc ('k') | chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

diff --git a/chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc b/chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

index ee1ce29822c958749e55e8b433eb5aba41ad003c..b819f7e08beb8e55eabc4f3bfd937ce966ca5e6b 100644

--- a/chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

+++ b/chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

@@ -29,7 +29,7 @@ const int kProxySettingsDialogReasonableHeight = 525;

const float kProxySettingsDialogReasonableWidthRatio = 0.4f;

const float kProxySettingsDialogReasonableHeightRatio = 0.4f;

-const char* kProxySettingsURLParam = "?network=%s";

+const char kProxySettingsURLParam[] = "?network=%s";

int CalculateSize(int screen_size, int min_comfortable, float desired_ratio) {

int desired_size = static_cast<int>(desired_ratio * screen_size);