chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/content_settings/content_settings_apitest.cc ('k') | chrome/browser/extensions/api/declarative_webrequest/webrequest_action_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc

diff --git a/chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc b/chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc

index 8d881e640daed34e7763b00fe471b88d0c0409c0..d6538b72c727ee4428d6cb75505172aff59a37fe 100644

--- a/chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc

+++ b/chrome/browser/extensions/api/declarative_content/request_content_script_apitest.cc

@@ -20,14 +20,14 @@ namespace extensions {

namespace {

// Manifest permissions injected into |kManifest|:

-const char* kPermissions[] = {

+const char* const kPermissions[] = {

"*://*/*", // ALL

"http://127.0.0.1/*", // PARTICULAR

"http://nowhere.com/*" // NOWHERE

};

// Script matchers for injected into |kBackgroundScriptSource|:

-const char* kScriptMatchers[] = {

+const char* const kScriptMatchers[] = {

"{ pageUrl: { hostContains: '' } }", // ALL

"{ pageUrl: { hostEquals: '127.0.0.1' } }", // PARTICULAR

"{ pageUrl: { hostEquals: 'nowhere.com' } }" // NOWHERE