chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc - Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

Issue 635573005: Cleanup: Better constify some strings in chrome/browser/{chromeos,extensions}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase, nit Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/alarms/alarms_api_unittest.cc ('k') | chrome/browser/extensions/api/content_settings/content_settings_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

diff --git a/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc b/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

index 96a79de5c9e63619449aad67df48d460e2ba99c3..bc8409fc4bb73e9f019391f7174922796470c704 100644

--- a/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

+++ b/chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.cc

@@ -66,7 +66,7 @@ void BrailleControllerImpl::TryLoadLibBrlApi() {

return;

// These versions of libbrlapi work the same for the functions we

// are using. (0.6.0 adds brlapi_writeWText).

- static const char* kSupportedVersions[] = {

+ static const char* const kSupportedVersions[] = {

"libbrlapi.so.0.5",

"libbrlapi.so.0.6"

};

@@ -277,7 +277,7 @@ void BrailleControllerImpl::DispatchKeys() {

VLOG(1) << "BrlAPI error: " << connection_->BrlapiStrError();

Disconnect();

return;

- } else if (result == 0) { // No more data.

+ } else if (result == 0) { // No more data.

return;

}

scoped_ptr<KeyEvent> event = BrlapiKeyCodeToEvent(code);