Remove base::Value::CreateNullValue

Remove base::Value::CreateNullValue

This change removes base::Value::CreateNullValue in favor of Value's default constructor. In particular, this change

- Replaces |Value::CreateNullValue()| with |MakeUnique<Value>()|.
  - Adds #includes of base/memory/ptr_util.h where needed.
  - Replaces |std::unique_ptr<Value>| with |auto| where appropriate.
- Replaces |*Value::CreateNullValue()| with |Value()|.
- Replaces |Value::CreateNullValue().release()| with |new Value()|.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2792573002
Cr-Commit-Position: refs/heads/master@{#462794}
Committed: https://chromium.googlesource.com/chromium/src/+/e067999ab52ac73c13981b100f3ebcf9c62ef817

[jdoerrie, 2017-03-31 12:53:22]

Description was changed from

==========
Remove base::Value::CreateNullValue

BUG=646113
==========

to

==========
Remove base::Value::CreateNullValue

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jdoerrie, 2017-03-31 13:17:39]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 13:17:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 14:06:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 14:06:37]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[jdoerrie, 2017-03-31 15:57:27]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-31 15:57:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-31 18:13:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-31 18:13:09]

Dry run: This issue passed the CQ dry run.

[jdoerrie, 2017-04-03 10:47:05]

Description was changed from

==========
Remove base::Value::CreateNullValue

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove base::Value::CreateNullValue

This change removes base::Value::CreateNullValue in favor of Value's default
constructor. In particular, this change

- Replaces |Value::CreateNullValue()| with |MakeUnique<Value>()|.
  - Adds #includes of base/memory/ptr_util.h where needed.
  - Replaces |std::unique_ptr<Value>| with |auto| where appropriate.
- Replaces |*Value::CreateNullValue()| with |Value()|.
- Replaces |Value::CreateNullValue().release()| with |new Value()|.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[jdoerrie, 2017-04-03 10:47:05]

jdoerrie@chromium.org changed reviewers:
+ brettw@chromium.org

[jdoerrie, 2017-04-03 10:58:23]

jdoerrie@chromium.org changed reviewers:
+ rsesek@chromium.org, stevenjb@chromium.org

[jdoerrie, 2017-04-03 10:58:24]

* brettw@: Please review base/values* and spot check the rest.

* stevenjb@: Please review chrome/browser/ui/webui/options/*

* rsesek@: Please review
  - components/arc/bluetooth/bluetooth_type_converters*
  - content/common/common_param_traits_unittest.cc
  - mojo/common/values_struct_traits.cc

[Robert Sesek, 2017-04-03 15:54:45]

LGTM

[stevenjb, 2017-04-03 17:31:12]

c/b/chromeos, c/b/ui/webui lgtm

[jdoerrie, 2017-04-06 14:36:46]

The CQ bit was checked by jdoerrie@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 14:37:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jdoerrie, 2017-04-06 14:37:47]

brettw@: A friendly ping to review this.

[commit-bot: I haz the power, 2017-04-06 16:53:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:53:59]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-04-06 19:44:17]

lgtm

[jdoerrie, 2017-04-07 06:32:48]

The CQ bit was checked by jdoerrie@chromium.org

[jdoerrie, 2017-04-07 06:32:49]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org,
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/2792573002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-07 06:33:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 06:39:05]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491546768830820,
"parent_rev": "2c6775c0307883f2c1cd1abdc1b9eaa7a2897164", "commit_rev":
"e067999ab52ac73c13981b100f3ebcf9c62ef817"}

[commit-bot: I haz the power, 2017-04-07 06:40:23]

Description was changed from

==========
Remove base::Value::CreateNullValue

This change removes base::Value::CreateNullValue in favor of Value's default
constructor. In particular, this change

- Replaces |Value::CreateNullValue()| with |MakeUnique<Value>()|.
  - Adds #includes of base/memory/ptr_util.h where needed.
  - Replaces |std::unique_ptr<Value>| with |auto| where appropriate.
- Replaces |*Value::CreateNullValue()| with |Value()|.
- Replaces |Value::CreateNullValue().release()| with |new Value()|.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Remove base::Value::CreateNullValue

This change removes base::Value::CreateNullValue in favor of Value's default
constructor. In particular, this change

- Replaces |Value::CreateNullValue()| with |MakeUnique<Value>()|.
  - Adds #includes of base/memory/ptr_util.h where needed.
  - Replaces |std::unique_ptr<Value>| with |auto| where appropriate.
- Replaces |*Value::CreateNullValue()| with |Value()|.
- Replaces |Value::CreateNullValue().release()| with |new Value()|.

BUG=646113
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2792573002
Cr-Commit-Position: refs/heads/master@{#462794}
Committed:
https://chromium.googlesource.com/chromium/src/+/e067999ab52ac73c13981b100f3e...
==========

[commit-bot: I haz the power, 2017-04-07 06:40:26]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e067999ab52ac73c13981b100f3e...