Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3844)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.cc ('k') | chrome/test/chromedriver/server/http_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index 6e228614e8c76be73b19d1403d4c1838129ccbbc..488bc45cf988b1fa228cdf016b2047e9e814cb25 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -372,7 +372,7 @@ class FindElementWebView : public StubWebView {
}
case kElementNotExistsQueryOnce: {
if (only_one_)
- result_ = base::Value::CreateNullValue();
+ result_ = base::MakeUnique<base::Value>();
else
result_.reset(new base::ListValue());
break;
@@ -407,7 +407,7 @@ class FindElementWebView : public StubWebView {
(scenario_ == kElementExistsQueryTwice && current_count_ == 1)) {
// Always return empty result when testing timeout.
if (only_one_)
- *result = base::Value::CreateNullValue();
+ *result = base::MakeUnique<base::Value>();
else
result->reset(new base::ListValue());
} else {
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.cc ('k') | chrome/test/chromedriver/server/http_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698