Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: components/sync_preferences/pref_model_associator_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync_preferences/pref_model_associator.h" 5 #include "components/sync_preferences/pref_model_associator.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "base/memory/ptr_util.h"
10 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
11 #include "base/values.h" 12 #include "base/values.h"
12 #include "components/prefs/scoped_user_pref_update.h" 13 #include "components/prefs/scoped_user_pref_update.h"
13 #include "components/sync_preferences/pref_model_associator_client.h" 14 #include "components/sync_preferences/pref_model_associator_client.h"
14 #include "components/sync_preferences/pref_service_mock_factory.h" 15 #include "components/sync_preferences/pref_service_mock_factory.h"
15 #include "components/sync_preferences/pref_service_syncable.h" 16 #include "components/sync_preferences/pref_service_syncable.h"
16 #include "testing/gtest/include/gtest/gtest.h" 17 #include "testing/gtest/include/gtest/gtest.h"
17 18
18 namespace sync_preferences { 19 namespace sync_preferences {
19 20
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
126 TEST_F(ListPreferenceMergeTest, LocalEmpty) { 127 TEST_F(ListPreferenceMergeTest, LocalEmpty) {
127 SetPrefToEmpty(kListPrefName); 128 SetPrefToEmpty(kListPrefName);
128 const PrefService::Preference* pref = 129 const PrefService::Preference* pref =
129 pref_service_->FindPreference(kListPrefName); 130 pref_service_->FindPreference(kListPrefName);
130 std::unique_ptr<base::Value> merged_value(pref_sync_service_->MergePreference( 131 std::unique_ptr<base::Value> merged_value(pref_sync_service_->MergePreference(
131 pref->name(), *pref->GetValue(), server_url_list_)); 132 pref->name(), *pref->GetValue(), server_url_list_));
132 EXPECT_TRUE(merged_value->Equals(&server_url_list_)); 133 EXPECT_TRUE(merged_value->Equals(&server_url_list_));
133 } 134 }
134 135
135 TEST_F(ListPreferenceMergeTest, ServerNull) { 136 TEST_F(ListPreferenceMergeTest, ServerNull) {
136 std::unique_ptr<base::Value> null_value = base::Value::CreateNullValue(); 137 auto null_value = base::MakeUnique<base::Value>();
137 { 138 {
138 ListPrefUpdate update(pref_service_.get(), kListPrefName); 139 ListPrefUpdate update(pref_service_.get(), kListPrefName);
139 base::ListValue* local_list_value = update.Get(); 140 base::ListValue* local_list_value = update.Get();
140 local_list_value->AppendString(local_url0_); 141 local_list_value->AppendString(local_url0_);
141 } 142 }
142 143
143 const PrefService::Preference* pref = 144 const PrefService::Preference* pref =
144 pref_service_->FindPreference(kListPrefName); 145 pref_service_->FindPreference(kListPrefName);
145 std::unique_ptr<base::Value> merged_value(pref_sync_service_->MergePreference( 146 std::unique_ptr<base::Value> merged_value(pref_sync_service_->MergePreference(
146 pref->name(), *pref->GetValue(), *null_value)); 147 pref->name(), *pref->GetValue(), *null_value));
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 TEST_F(DictionaryPreferenceMergeTest, LocalEmpty) { 249 TEST_F(DictionaryPreferenceMergeTest, LocalEmpty) {
249 SetPrefToEmpty(kDictionaryPrefName); 250 SetPrefToEmpty(kDictionaryPrefName);
250 const PrefService::Preference* pref = 251 const PrefService::Preference* pref =
251 pref_service_->FindPreference(kDictionaryPrefName); 252 pref_service_->FindPreference(kDictionaryPrefName);
252 std::unique_ptr<base::Value> merged_value(pref_sync_service_->MergePreference( 253 std::unique_ptr<base::Value> merged_value(pref_sync_service_->MergePreference(
253 pref->name(), *pref->GetValue(), server_patterns_)); 254 pref->name(), *pref->GetValue(), server_patterns_));
254 EXPECT_TRUE(merged_value->Equals(&server_patterns_)); 255 EXPECT_TRUE(merged_value->Equals(&server_patterns_));
255 } 256 }
256 257
257 TEST_F(DictionaryPreferenceMergeTest, ServerNull) { 258 TEST_F(DictionaryPreferenceMergeTest, ServerNull) {
258 std::unique_ptr<base::Value> null_value = base::Value::CreateNullValue(); 259 auto null_value = base::MakeUnique<base::Value>();
259 { 260 {
260 DictionaryPrefUpdate update(pref_service_.get(), kDictionaryPrefName); 261 DictionaryPrefUpdate update(pref_service_.get(), kDictionaryPrefName);
261 base::DictionaryValue* local_dict_value = update.Get(); 262 base::DictionaryValue* local_dict_value = update.Get();
262 SetContentPattern(local_dict_value, expression3_, 1); 263 SetContentPattern(local_dict_value, expression3_, 1);
263 } 264 }
264 265
265 const PrefService::Preference* pref = 266 const PrefService::Preference* pref =
266 pref_service_->FindPreference(kDictionaryPrefName); 267 pref_service_->FindPreference(kDictionaryPrefName);
267 std::unique_ptr<base::Value> merged_value(pref_sync_service_->MergePreference( 268 std::unique_ptr<base::Value> merged_value(pref_sync_service_->MergePreference(
268 pref->name(), *pref->GetValue(), *null_value)); 269 pref->name(), *pref->GetValue(), *null_value));
(...skipping 162 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 base::DictionaryValue server_patterns_; 432 base::DictionaryValue server_patterns_;
432 }; 433 };
433 434
434 TEST_F(IndividualPreferenceMergeTest, ListPreference) { 435 TEST_F(IndividualPreferenceMergeTest, ListPreference) {
435 EXPECT_TRUE(MergeListPreference(kListPrefName)); 436 EXPECT_TRUE(MergeListPreference(kListPrefName));
436 } 437 }
437 438
438 } // namespace 439 } // namespace
439 440
440 } // namespace sync_preferences 441 } // namespace sync_preferences
OLDNEW
« no previous file with comments | « components/policy/core/common/schema_unittest.cc ('k') | components/sync_preferences/pref_service_syncable_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698