Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Unified Diff: content/common/common_param_traits_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/common_param_traits_unittest.cc
diff --git a/content/common/common_param_traits_unittest.cc b/content/common/common_param_traits_unittest.cc
index c5acf22ac2f080e9fd6916ffd7efcb6dbcf41ce1..c9006cf39b5f58573ce1ece582a7ab821903c291 100644
--- a/content/common/common_param_traits_unittest.cc
+++ b/content/common/common_param_traits_unittest.cc
@@ -11,6 +11,7 @@
#include <utility>
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "content/public/common/content_constants.h"
#include "ipc/ipc_message.h"
@@ -84,7 +85,7 @@ TEST(IPCMessageTest, ListValue) {
base::ListValue input;
input.Set(0, new base::Value(42.42));
input.Set(1, new base::Value("forty"));
- input.Set(2, base::Value::CreateNullValue());
+ input.Set(2, base::MakeUnique<base::Value>());
IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
IPC::WriteParam(&msg, input);
@@ -104,7 +105,7 @@ TEST(IPCMessageTest, ListValue) {
TEST(IPCMessageTest, DictionaryValue) {
base::DictionaryValue input;
- input.Set("null", base::Value::CreateNullValue());
+ input.Set("null", base::MakeUnique<base::Value>());
input.Set("bool", new base::Value(true));
input.Set("int", new base::Value(42));
« no previous file with comments | « content/child/v8_value_converter_impl_unittest.cc ('k') | content/renderer/java/gin_java_function_invocation_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698