Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Unified Diff: headless/lib/browser/headless_devtools_client_impl.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/script_injection.cc ('k') | ios/web/web_state/ui/web_view_js_utils.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/browser/headless_devtools_client_impl.cc
diff --git a/headless/lib/browser/headless_devtools_client_impl.cc b/headless/lib/browser/headless_devtools_client_impl.cc
index ff0c2aaca221a468cf0186ce927028ea8a703793..ca315fa14a403cfd0b876dbb9653ec73591ac374 100644
--- a/headless/lib/browser/headless_devtools_client_impl.cc
+++ b/headless/lib/browser/headless_devtools_client_impl.cc
@@ -129,7 +129,7 @@ bool HeadlessDevToolsClientImpl::DispatchMessageReply(
if (message_dict.GetDictionary("result", &result_dict)) {
callback.callback_with_result.Run(*result_dict);
} else if (message_dict.GetDictionary("error", &result_dict)) {
- std::unique_ptr<base::Value> null_value = base::Value::CreateNullValue();
+ auto null_value = base::MakeUnique<base::Value>();
DLOG(ERROR) << "Error in method call result: " << *result_dict;
callback.callback_with_result.Run(*null_value);
} else {
« no previous file with comments | « extensions/renderer/script_injection.cc ('k') | ios/web/web_state/ui/web_view_js_utils.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698