chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/reset_settings_handler.cc ('k') | chrome/browser/ui/webui/settings/settings_cookies_view_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

diff --git a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

index 70be7a452aae8a55ab4e14029c7d1b883d89839b..2c47be3d7161c3bdfd610ca102bb648f07e01539 100644

--- a/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

+++ b/chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc

@@ -262,9 +262,7 @@ void ClearBrowsingDataHandler::HandleInitialize(const base::ListValue* args) {

for (const auto& counter : counters_)

counter->Restart();

- ResolveJavascriptCallback(

- *callback_id,

- *base::Value::CreateNullValue() /* Promise<void> */);

+ ResolveJavascriptCallback(*callback_id, base::Value() /* Promise<void> */);

}

void ClearBrowsingDataHandler::OnStateChanged(syncer::SyncService* sync) {