Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5973)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index e81549904d51444addc50ade41cdd243ea246acc..08a77e2290a517292c0844a5ea6781195b74cf5b 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2064,10 +2064,10 @@ void RenderFrameImpl::JavaScriptIsolatedWorldRequest::completed(
std::unique_ptr<base::Value> result_value(
converter.FromV8Value(value, context));
list.Append(result_value ? std::move(result_value)
- : base::Value::CreateNullValue());
+ : base::MakeUnique<base::Value>());
}
} else {
- list.Set(0, base::Value::CreateNullValue());
+ list.Set(0, base::MakeUnique<base::Value>());
}
render_frame_impl_.get()->Send(
new FrameHostMsg_JavaScriptExecuteResponse(routing_id_, id_, list));
@@ -2092,9 +2092,9 @@ void RenderFrameImpl::HandleJavascriptExecutionResult(
std::unique_ptr<base::Value> result_value(
converter.FromV8Value(result, context));
list.Set(0, result_value ? std::move(result_value)
- : base::Value::CreateNullValue());
+ : base::MakeUnique<base::Value>());
} else {
- list.Set(0, base::Value::CreateNullValue());
+ list.Set(0, base::MakeUnique<base::Value>());
}
Send(new FrameHostMsg_JavaScriptExecuteResponse(routing_id_, id, list));
}
« no previous file with comments | « content/renderer/java/gin_java_function_invocation_helper.cc ('k') | content/renderer/stats_collection_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698