components/policy/core/common/schema_map_unittest.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/schema_map_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/policy/core/common/schema_map_unittest.cc

diff --git a/components/policy/core/common/schema_map_unittest.cc b/components/policy/core/common/schema_map_unittest.cc

index 5913ee1cd14fa57d012b0e9856ab25505150a82a..b99bc8af49d01d50e25735a436642e2c78b398ad 100644

--- a/components/policy/core/common/schema_map_unittest.cc

+++ b/components/policy/core/common/schema_map_unittest.cc

@@ -166,7 +166,7 @@ TEST_F(SchemaMapTest, FilterBundle) {

map.Set("integer", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(1), nullptr);

map.Set("null", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

- POLICY_SOURCE_CLOUD, base::Value::CreateNullValue(), nullptr);

+ POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(), nullptr);

map.Set("double", POLICY_LEVEL_MANDATORY, POLICY_SCOPE_USER,

POLICY_SOURCE_CLOUD, base::MakeUnique<base::Value>(1.2), nullptr);

base::DictionaryValue dict;