Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1536)

Unified Diff: content/renderer/java/gin_java_function_invocation_helper.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/common_param_traits_unittest.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/java/gin_java_function_invocation_helper.cc
diff --git a/content/renderer/java/gin_java_function_invocation_helper.cc b/content/renderer/java/gin_java_function_invocation_helper.cc
index 9bdf7442ab910500c40d74cefdbc93659f7365d5..af300a2e229f4e197c5a2c8ced7287a7050e9e21 100644
--- a/content/renderer/java/gin_java_function_invocation_helper.cc
+++ b/content/renderer/java/gin_java_function_invocation_helper.cc
@@ -4,6 +4,7 @@
#include "content/renderer/java/gin_java_function_invocation_helper.h"
+#include "base/memory/ptr_util.h"
#include "content/common/android/gin_java_bridge_errors.h"
#include "content/common/android/gin_java_bridge_value.h"
#include "content/public/child/v8_value_converter.h"
@@ -65,7 +66,7 @@ v8::Local<v8::Value> GinJavaFunctionInvocationHelper::Invoke(
if (arg.get()) {
arguments.Append(arg.release());
} else {
- arguments.Append(base::Value::CreateNullValue());
+ arguments.Append(base::MakeUnique<base::Value>());
}
}
}
« no previous file with comments | « content/common/common_param_traits_unittest.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698