Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2194)

Unified Diff: chrome/test/chromedriver/capabilities_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/capabilities_unittest.cc
diff --git a/chrome/test/chromedriver/capabilities_unittest.cc b/chrome/test/chromedriver/capabilities_unittest.cc
index a1a3e7ff248f9aa6e8ffa9783bb0d0421b830912..32fcd26fc1e6a1053c6f6610d9dd6b2ebd7fa1c0 100644
--- a/chrome/test/chromedriver/capabilities_unittest.cc
+++ b/chrome/test/chromedriver/capabilities_unittest.cc
@@ -4,6 +4,7 @@
#include "chrome/test/chromedriver/capabilities.h"
+#include "base/memory/ptr_util.h"
#include "base/values.h"
#include "chrome/test/chromedriver/chrome/log.h"
#include "chrome/test/chromedriver/chrome/status.h"
@@ -304,8 +305,8 @@ TEST(ParseCapabilities, IgnoreNullValueForManualProxy) {
base::DictionaryValue proxy;
proxy.SetString("proxyType", "manual");
proxy.SetString("ftpProxy", "localhost:9001");
- proxy.Set("sslProxy", base::Value::CreateNullValue());
- proxy.Set("noProxy", base::Value::CreateNullValue());
+ proxy.Set("sslProxy", base::MakeUnique<base::Value>());
+ proxy.Set("noProxy", base::MakeUnique<base::Value>());
base::DictionaryValue caps;
caps.Set("proxy", proxy.DeepCopy());
Status status = capabilities.Parse(caps);
« no previous file with comments | « chrome/browser/ui/webui/supervised_user_internals_message_handler.cc ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698