chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc

diff --git a/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc b/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc

index 02e14062d8206ac75c093d31f53ce110101ad625..28900b32090087912a5c60bcaeef5706fec0019c 100644

--- a/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc

+++ b/chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc

@@ -131,7 +131,7 @@ void StartupPagesHandler::HandleEditStartupPage(const base::ListValue* args) {

CHECK(args->GetInteger(1, &index));

if (index < 0 || index > startup_custom_pages_table_model_.RowCount()) {

- RejectJavascriptCallback(*callback_id, *base::Value::CreateNullValue());

+ RejectJavascriptCallback(*callback_id, base::Value());

NOTREACHED();

return;

}