Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1466)

Unified Diff: content/child/v8_value_converter_impl_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/common_param_traits_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/v8_value_converter_impl_unittest.cc
diff --git a/content/child/v8_value_converter_impl_unittest.cc b/content/child/v8_value_converter_impl_unittest.cc
index 2997770e8239095678e1a733f787b4e8574eb4c1..394af66db0f36528d05dcd570cf49a9a4ebe3478 100644
--- a/content/child/v8_value_converter_impl_unittest.cc
+++ b/content/child/v8_value_converter_impl_unittest.cc
@@ -814,7 +814,7 @@ TEST_F(V8ValueConverterImplTest, DetectCycles) {
// The first repetition should be trimmed and replaced by a null value.
base::ListValue expected_list;
- expected_list.Append(base::Value::CreateNullValue());
+ expected_list.Append(base::MakeUnique<base::Value>());
// The actual result.
std::unique_ptr<base::Value> actual_list(
@@ -835,7 +835,7 @@ TEST_F(V8ValueConverterImplTest, DetectCycles) {
// The first repetition should be trimmed and replaced by a null value.
base::DictionaryValue expected_dictionary;
- expected_dictionary.Set(key, base::Value::CreateNullValue());
+ expected_dictionary.Set(key, base::MakeUnique<base::Value>());
// The actual result.
std::unique_ptr<base::Value> actual_dictionary(
« no previous file with comments | « content/child/v8_value_converter_impl.cc ('k') | content/common/common_param_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698