Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(844)

Unified Diff: media/base/video_frame_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_message_utils_unittest.cc ('k') | mojo/common/common_custom_types_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_frame_unittest.cc
diff --git a/media/base/video_frame_unittest.cc b/media/base/video_frame_unittest.cc
index 1d400f639d9d96d05b51525bb27c33484513b825..775245b545533f1eb27f4aa6fc5404e64d6baa7a 100644
--- a/media/base/video_frame_unittest.cc
+++ b/media/base/video_frame_unittest.cc
@@ -12,6 +12,7 @@
#include "base/format_macros.h"
#include "base/macros.h"
#include "base/memory/aligned_memory.h"
+#include "base/memory/ptr_util.h"
#include "base/strings/stringprintf.h"
#include "gpu/command_buffer/common/mailbox_holder.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -539,7 +540,7 @@ TEST(VideoFrameMetadata, SetAndThenGetAllKeysForAllTypes) {
metadata.Clear();
EXPECT_FALSE(metadata.HasKey(key));
- metadata.SetValue(key, base::Value::CreateNullValue());
+ metadata.SetValue(key, base::MakeUnique<base::Value>());
EXPECT_TRUE(metadata.HasKey(key));
const base::Value* const null_value = metadata.GetValue(key);
EXPECT_TRUE(null_value);
« no previous file with comments | « ipc/ipc_message_utils_unittest.cc ('k') | mojo/common/common_custom_types_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698