extensions/browser/api/socket/socket_api.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/socket/socket_api.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/socket/socket_api.cc

diff --git a/extensions/browser/api/socket/socket_api.cc b/extensions/browser/api/socket/socket_api.cc

index 4ec44356254c0ed788a48036f0ce8a4bcd718d48..e64c2724337b7299e0e08cec75a2a2c6f0c60609 100644

--- a/extensions/browser/api/socket/socket_api.cc

+++ b/extensions/browser/api/socket/socket_api.cc

@@ -362,7 +362,7 @@ void SocketDisconnectFunction::Work() {

socket->Disconnect(false /* socket_destroying */);

else

error_ = kSocketNotFoundError;

- SetResult(base::Value::CreateNullValue());

+ SetResult(base::MakeUnique<base::Value>());

}

bool SocketBindFunction::Prepare() {