ios/web/web_state/ui/web_view_js_utils.mm - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/web_view_js_utils.mm

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/web_view_js_utils.mm

diff --git a/ios/web/web_state/ui/web_view_js_utils.mm b/ios/web/web_state/ui/web_view_js_utils.mm

index b7aade3225a1371e29a1eb1c7967d6d6c3b3a5a9..1afe2d8a9ba9d9cbe6f6463aa4df09fa90d931a6 100644

--- a/ios/web/web_state/ui/web_view_js_utils.mm

+++ b/ios/web/web_state/ui/web_view_js_utils.mm

@@ -41,7 +41,7 @@ std::unique_ptr<base::Value> ValueResultFromWKResult(id wk_result,

result.reset(new base::Value(static_cast<bool>([wk_result boolValue])));

DCHECK(result->IsType(base::Value::Type::BOOLEAN));

} else if (result_type == CFNullGetTypeID()) {

- result = base::Value::CreateNullValue();

+ result = base::MakeUnique<base::Value>();

DCHECK(result->IsType(base::Value::Type::NONE));

} else if (result_type == CFDictionaryGetTypeID()) {

std::unique_ptr<base::DictionaryValue> dictionary =

« no previous file with comments | « headless/lib/browser/headless_devtools_client_impl.cc ('k') | ipc/ipc_message_unittest.cc » ('j') | no next file with comments »