extensions/browser/app_window/app_window.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/app_window/app_window.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/app_window/app_window.cc

diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc

index 6d52ad22e934d4cd93892d50f5f57a97cc8d0a75..20edc89c651d05ae3b6b56fdce0fbbb14ddca208 100644

--- a/extensions/browser/app_window/app_window.cc

+++ b/extensions/browser/app_window/app_window.cc

@@ -81,7 +81,7 @@ void SetConstraintProperty(const std::string& name,

if (value != SizeConstraints::kUnboundedSize)

bounds_properties->SetInteger(name, value);

else

- bounds_properties->Set(name, base::Value::CreateNullValue());

+ bounds_properties->Set(name, base::MakeUnique<base::Value>());

}

void SetBoundsProperties(const gfx::Rect& bounds,