Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: components/arc/bluetooth/bluetooth_type_converters.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/bluetooth/bluetooth_type_converters.cc
diff --git a/components/arc/bluetooth/bluetooth_type_converters.cc b/components/arc/bluetooth/bluetooth_type_converters.cc
index 33b1a9f3569457517e0dc1af5772dbd13ca65735..03cbd21ffb94f05fb826ef395c7c95aa9e3ea2c1 100644
--- a/components/arc/bluetooth/bluetooth_type_converters.cc
+++ b/components/arc/bluetooth/bluetooth_type_converters.cc
@@ -127,7 +127,7 @@ TypeConverter<arc::mojom::BluetoothSdpAttributePtr,
switch (result->type) {
case bluez::BluetoothServiceAttributeValueBlueZ::NULLTYPE:
- result->value.Append(base::Value::CreateNullValue());
+ result->value.Append(base::MakeUnique<base::Value>());
break;
case bluez::BluetoothServiceAttributeValueBlueZ::UINT:
case bluez::BluetoothServiceAttributeValueBlueZ::INT:
@@ -142,7 +142,7 @@ TypeConverter<arc::mojom::BluetoothSdpAttributePtr,
if (depth + 1 >= arc::kBluetoothSDPMaxDepth) {
result->type = bluez::BluetoothServiceAttributeValueBlueZ::NULLTYPE;
result->type_size = 0;
- result->value.Append(base::Value::CreateNullValue());
+ result->value.Append(base::MakeUnique<base::Value>());
return result;
}
for (const auto& child : attr_bluez.sequence()) {
@@ -177,7 +177,7 @@ TypeConverter<bluez::BluetoothServiceAttributeValueBlueZ,
if (attr->value.GetSize() != 1) {
return bluez::BluetoothServiceAttributeValueBlueZ(
bluez::BluetoothServiceAttributeValueBlueZ::NULLTYPE, 0,
- base::Value::CreateNullValue());
+ base::MakeUnique<base::Value>());
}
std::unique_ptr<base::Value> value;
@@ -190,7 +190,7 @@ TypeConverter<bluez::BluetoothServiceAttributeValueBlueZ,
if (depth + 1 >= arc::kBluetoothSDPMaxDepth || attr->sequence.empty()) {
return bluez::BluetoothServiceAttributeValueBlueZ(
bluez::BluetoothServiceAttributeValueBlueZ::NULLTYPE, 0,
- base::Value::CreateNullValue());
+ base::MakeUnique<base::Value>());
}
auto bluez_sequence = base::MakeUnique<
@@ -207,7 +207,7 @@ TypeConverter<bluez::BluetoothServiceAttributeValueBlueZ,
}
return bluez::BluetoothServiceAttributeValueBlueZ(
bluez::BluetoothServiceAttributeValueBlueZ::NULLTYPE, 0,
- base::Value::CreateNullValue());
+ base::MakeUnique<base::Value>());
}
// static
« no previous file with comments | « chrome/test/chromedriver/server/http_handler.cc ('k') | components/arc/bluetooth/bluetooth_type_converters_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698