Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: ipc/ipc_message_utils_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | media/base/video_frame_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ipc/ipc_message_utils_unittest.cc
diff --git a/ipc/ipc_message_utils_unittest.cc b/ipc/ipc_message_utils_unittest.cc
index 36b0dbddc4983de52ce15025fc31dc7fe8fe108a..4a10d34e2c45dcc7b36bf9d10e6136062db347b5 100644
--- a/ipc/ipc_message_utils_unittest.cc
+++ b/ipc/ipc_message_utils_unittest.cc
@@ -10,6 +10,7 @@
#include "base/files/file_path.h"
#include "base/json/json_reader.h"
+#include "base/memory/ptr_util.h"
#include "base/unguessable_token.h"
#include "ipc/ipc_channel_handle.h"
#include "ipc/ipc_message.h"
@@ -100,7 +101,7 @@ TEST(IPCMessageUtilsTest, ValueSize) {
value->SetWithoutPathExpansion("foo", new base::Value(42));
value->SetWithoutPathExpansion("bar", new base::Value(3.14));
value->SetWithoutPathExpansion("baz", new base::Value("hello"));
- value->SetWithoutPathExpansion("qux", base::Value::CreateNullValue());
+ value->SetWithoutPathExpansion("qux", base::MakeUnique<base::Value>());
std::unique_ptr<base::DictionaryValue> nested_dict(new base::DictionaryValue);
nested_dict->SetWithoutPathExpansion("foobar", new base::Value(5));
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | media/base/video_frame_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698