extensions/renderer/api_signature.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/api_signature.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/api_signature.cc

diff --git a/extensions/renderer/api_signature.cc b/extensions/renderer/api_signature.cc

index 733ec8ed491c9caa5ab89ebbf19dae0856a2817a..d33423411d2ce454b245e270596318cb1e1f3ff2 100644

--- a/extensions/renderer/api_signature.cc

+++ b/extensions/renderer/api_signature.cc

@@ -132,7 +132,7 @@ class BaseValueArgumentParser : public ArgumentParser {

private:

void AddNull() override {

- list_value_->Append(base::Value::CreateNullValue());

+ list_value_->Append(base::MakeUnique<base::Value>());

}

void AddNullCallback() override {

// The base::Value conversion doesn't include the callback directly, so we