Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5820)

Unified Diff: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
index 342e88fdd87dcaffa15fdcb452d6d82b1198576d..5f5e0312b657ef5cd884110b3942452a4867f619 100644
--- a/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
+++ b/chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc
@@ -177,7 +177,7 @@ base::Value* CoreChromeOSOptionsHandler::FetchPref(
base::Value* value = nullptr;
proxy_cros_settings_parser::GetProxyPrefValue(
network_guid_, pref_name, GetUiProxyConfigService(), &value);
- return value ? value : base::Value::CreateNullValue().release();
+ return value ? value : new base::Value();
}
Profile* profile = Profile::FromWebUI(web_ui());
@@ -205,7 +205,7 @@ base::Value* CoreChromeOSOptionsHandler::FetchPref(
const base::Value* pref_value = CrosSettings::Get()->GetPref(pref_name);
if (!pref_value)
- return base::Value::CreateNullValue().release();
+ return new base::Value();
// Decorate pref value as CoreOptionsHandler::CreateValueForPref() does.
// TODO(estade): seems that this should replicate CreateValueForPref less.

Powered by Google App Engine
This is Rietveld 408576698