chrome/browser/ui/webui/supervised_user_internals_message_handler.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/settings/site_settings_handler.cc ('k') | chrome/test/chromedriver/capabilities_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

diff --git a/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc b/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

index 63e4126215e0c89ed3db4fa3f0ffaf5c91afe5ad..f9ca895383ec752f1d3511900631b2334a41fab2 100644

--- a/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

+++ b/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

@@ -8,6 +8,7 @@

#include "base/bind.h"

#include "base/macros.h"

+#include "base/memory/ptr_util.h"

#include "base/memory/ref_counted.h"

#include "base/strings/string_util.h"

#include "base/strings/stringprintf.h"

@@ -245,7 +246,7 @@ void SupervisedUserInternalsMessageHandler::SendSupervisedUserSettings(

const base::DictionaryValue* settings) {

web_ui()->CallJavascriptFunctionUnsafe(

"chrome.supervised_user_internals.receiveUserSettings",

- *(settings ? settings : base::Value::CreateNullValue().get()));

+ *(settings ? settings : base::MakeUnique<base::Value>().get()));

}

void SupervisedUserInternalsMessageHandler::OnTryURLResult(

« no previous file with comments | « chrome/browser/ui/webui/settings/site_settings_handler.cc ('k') | chrome/test/chromedriver/capabilities_unittest.cc » ('j') | no next file with comments »