mojo/common/values_struct_traits.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/common/values_struct_traits.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/common/values_struct_traits.cc

diff --git a/mojo/common/values_struct_traits.cc b/mojo/common/values_struct_traits.cc

index 6af7a395338804f1c9b8b0eda06ee5ee8ca403d0..ef88a09cdfd9a8b85d0bcc3baa7f94a3bc3b935a 100644

--- a/mojo/common/values_struct_traits.cc

+++ b/mojo/common/values_struct_traits.cc

@@ -58,7 +58,7 @@ bool UnionTraits<common::mojom::ValueDataView, std::unique_ptr<base::Value>>::

std::unique_ptr<base::Value>* value_out) {

switch (data.tag()) {

case common::mojom::ValueDataView::Tag::NULL_VALUE: {

- *value_out = base::Value::CreateNullValue();

+ *value_out = base::MakeUnique<base::Value>();

return true;

}

case common::mojom::ValueDataView::Tag::BOOL_VALUE: {