chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc ('k') | chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

diff --git a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

index a785c2556524aaca483f3b9a50763f05898280f1..c924a72f36c277058c8559ec3cf04d55ca00c5c6 100644

--- a/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

+++ b/chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc

@@ -361,7 +361,7 @@ void LocalDiscoveryUIHandler::DeviceChanged(

web_ui()->CallJavascriptFunctionUnsafe(

"local_discovery.onUnregisteredDeviceUpdate", service_key, info);

} else {

- std::unique_ptr<base::Value> null_value = base::Value::CreateNullValue();

+ auto null_value = base::MakeUnique<base::Value>();

web_ui()->CallJavascriptFunctionUnsafe(

"local_discovery.onUnregisteredDeviceUpdate", service_key, *null_value);

@@ -370,7 +370,7 @@ void LocalDiscoveryUIHandler::DeviceChanged(

void LocalDiscoveryUIHandler::DeviceRemoved(const std::string& name) {

device_descriptions_.erase(name);

- std::unique_ptr<base::Value> null_value = base::Value::CreateNullValue();

+ auto null_value = base::MakeUnique<base::Value>();

base::Value name_value(kKeyPrefixMDns + name);

web_ui()->CallJavascriptFunctionUnsafe(