components/sync_preferences/pref_service_syncable_unittest.cc - Issue 2792573002: Remove base::Value::CreateNullValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_preferences/pref_service_syncable_unittest.cc

Issue 2792573002: Remove base::Value::CreateNullValue (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync_preferences/pref_service_syncable_unittest.cc

diff --git a/components/sync_preferences/pref_service_syncable_unittest.cc b/components/sync_preferences/pref_service_syncable_unittest.cc

index 676c5f27a613e659411341ac722337d6d8233e7c..008446ba150b79aafbdd6618ab1902b740dbcca8 100644

--- a/components/sync_preferences/pref_service_syncable_unittest.cc

+++ b/components/sync_preferences/pref_service_syncable_unittest.cc

@@ -539,7 +539,7 @@ TEST_F(PrefServiceSyncableTest, DeletePreference) {

InitWithNoSyncData();

- std::unique_ptr<base::Value> null_value = base::Value::CreateNullValue();

+ auto null_value = base::MakeUnique<base::Value>();

syncer::SyncChangeList list;

list.push_back(MakeRemoteChange(1, kStringPrefName, *null_value,

SyncChange::ACTION_DELETE));